search

gusparis / react-native-month-year-picker

React Native Month Picker component for iOS & Android
MIT License
107 stars 75 forks source link

Update build.gradle to support React 0.69.0 & Gradle 7 #125

Closed cluth17 closed 2 years ago

cluth17 commented 2 years ago

compile has been removed. replacing with implementation.

cluth17 commented 2 years ago

Can this get merged? I've tested in my local and this is the last thing needed to support gradle 7.

harpreetCD commented 2 years ago

Hi, I have tried your patch. but it is giving Plugin with id 'maven' not found. I guess moving to implementation is also required but maven plugin is also not supported. Please verify

cluth17 commented 2 years ago

This PR in combination with this PR (https://github.com/gusparis/react-native-month-year-picker/pull/116) should fix all the Gradle 7 issues. The other PR has already been merged but not deployed to npm. @harpreetCD

harpreetCD commented 2 years ago

not deployed because the publish script is removed in that PR? 🙄

nimeshkavinda commented 2 years ago

Any idea when this will be merged? need this fix asap

nimeshkavinda commented 2 years ago

Hi, I have tried your patch. but it is giving Plugin with id 'maven' not found. I guess moving to implementation is also required but maven plugin is also not supported. Please verify

This should be renamed to "maven-publish"

gusparis commented 2 years ago

Hey! sorry I've been having some personal issues. I will be getting everything up-to-date