search

gusparis / react-native-month-year-picker

React Native Month Picker component for iOS & Android
MIT License
107 stars 76 forks source link

Could not resolve com.facebook.react:react-native:+ #134

Closed edosetia closed 2 years ago

edosetia commented 2 years ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-month-year-picker@1.8.2 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-month-year-picker/android/build.gradle b/node_modules/react-native-month-year-picker/android/build.gradle
index 2455914..c57cbf0 100644
--- a/node_modules/react-native-month-year-picker/android/build.gradle
+++ b/node_modules/react-native-month-year-picker/android/build.gradle
@@ -112,7 +112,6 @@ afterEvaluate { project ->
         source = android.sourceSets.main.java.srcDirs
         classpath += files(android.bootClasspath)
         project.getConfigurations().getByName('implementation').setCanBeResolved(true)
-        classpath += files(project.getConfigurations().getByName('implementation').asList())

         include '**/*.java'
     }

This issue body was partially generated by patch-package.

onnij commented 2 years ago

I think the actual root cause is probably because of this:

https://github.com/facebook/react-native/issues/35210

gusparis commented 2 years ago

Fixed on #140. Can you guys check?