search

gusparis / react-native-month-year-picker

React Native Month Picker component for iOS & Android
MIT License
106 stars 74 forks source link

localization #34

Closed waohwaohwaoh closed 3 years ago

waohwaohwaoh commented 3 years ago

Hello, can you please tell me how to make localization for this picker, or is this function not yet implemented? If not, is it planned to be implemented in the near future?

gusparis commented 3 years ago

Hello @waohwaohwaoh and thank you for using the library! Currently, the month names are being fetch on native sides, both by Java and Objective-C getting localized names based on phone settings. Is that what you need? Regards.

waohwaohwaoh commented 3 years ago

Thanks for the quick answer, yes this is what I want, but on my emulator, the Russian language is specified in the settings, the names of the months are still in English. Does this work on an emulator or only on real devices?

gusparis commented 3 years ago

mmm I really don't remember if it worked on the sim. Let me check on my personal device that's in Spanish.

Edit: @waohwaohwaoh You're right, not seem to be fetching the correct localized name on iOS. Android works as expected. I Will work on an iOS fix.

waohwaohwaoh commented 3 years ago

Thanks for your work on the library and for your quick response. Could you please tell us the approximate terms of elimination of this defect

gusparis commented 3 years ago

:tada: This issue has been resolved in version 1.3.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

gusparis commented 3 years ago

@waohwaohwaoh it was an easy fix. CI is already running...waiting for new version to be published

waohwaohwaoh commented 3 years ago

a lot thx you, I will follow the update