Closed gussmith23 closed 2 years ago
@gussmith23 can you give any example , I understood the clippy part but how to fail on warnings
it may be enough to just run "cargo clippy". I want CI to fail if clippy throws any warnings, but we can start by just running clippy in CI!
@gussmith23 In which file do you want to add or else should i go for new Yaml file?
a new file should be great, you can copy the rustfmt file!
On Mon, Feb 14, 2022, 10:21 PM Rishi Kumar Ray @.***> wrote:
@gussmith23 https://github.com/gussmith23 In which file do you want to add or else should i go for new Yaml file?
— Reply to this email directly, view it on GitHub https://github.com/gussmith23/glenside/issues/169#issuecomment-1039901136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJFZAN52SIQ2P62W6PJX73U3HWHRANCNFSM5OMN6GBQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
@gussmith23 can you please check this? https://github.com/RishiKumarRay/glenside/commit/76dc0c688e221d57cea6c6648be4a676bfb06434 though it is failing but i think there might be some issue with formatting that it will pass
Can you open a pull request and set me as the reviewer?
@gussmith23 yeah i have created it please do check
Run
cargo clippy
in CI and fail on warnings.