gustaveroudproject / roud-oeuvres-app

« Gustave Roud, Œuvres complètes », Université de Lausanne + DaSCH
https://www.unil.ch/clsr/home/menuinst/projets-de-recherche/gustave-roud-oeuvres-completes.html
GNU General Public License v3.0
3 stars 0 forks source link

publication missing diary notes #303

Closed loicjaouen closed 2 years ago

loicjaouen commented 2 years ago

http://localhost:4200/archive/pub/http%253A%252F%252Frdfh.ch%252F0112%252F_CWQItLmRciQ_ALN0F03JA section "Notes de journal" is empty where it should list:

Pour la partie : « Bouvreuil »
« Bouvreuil » (partie de : [CLSR GR MS 4 D/6a](https://roud.unil.ch/resources/http%253A%252F%252Frdfh.ch%252F0112%252FyK4RcqWISw-Cy2bjs1NIuA))
Pour la partie : « Sous trois lampes… »
« Walens[tadt] (14-19. II. 21) » (partie de : [CLSR GR MS 4 A/12a](https://roud.unil.ch/resources/http%253A%252F%252Frdfh.ch%252F0112%252FgDL0r7tZSomwqOJT70qfPg))
loicjaouen commented 2 years ago

that part is generated in pub-page/pub-page.component.html#L131

from data in diaryNotes and pubPartsLight

loicjaouen commented 2 years ago

the missing part is labeled "Pour la partie: " so it is pubPartsLight that we miss

loicjaouen commented 2 years ago

checked the query, its result, it is all fine

loicjaouen commented 2 years ago

it does not show up because of : css liPart: display: none

which is changed by pub-page.component.ts#L399 which counts the number of sub <span> elements.

To unify the cases (in diary, genesis, etc), an empty span was added there, that I removed for the sake of clarity...

putting it back.

loicjaouen commented 2 years ago

here it was @elespdn ;)

elespdn commented 2 years ago

Oh, great that you found out!