gustaveroudproject / roud-oeuvres-app

« Gustave Roud, Œuvres complètes », Université de Lausanne + DaSCH
https://www.unil.ch/clsr/home/menuinst/projets-de-recherche/gustave-roud-oeuvres-completes.html
GNU General Public License v3.0
3 stars 0 forks source link

dsp-api release v25 and its breaking changes #315

Closed loicjaouen closed 1 year ago

loicjaouen commented 1 year ago

The DaSCH will release a dsp-api:v25 version with a breaking change, the project's code will change:

- http://rdfh.ch/projects/0112
+ http://rdfh.ch/projects/QNSP2JJRTEyh6A0ZtpRdPQ
loicjaouen commented 1 year ago

a code review shows that the project ID is extensively used (in all text search) but is systematically obtained by a method call.

loicjaouen commented 1 year ago

made changes in the above PR

loicjaouen commented 1 year ago

plugged into ls-test to check

loicjaouen commented 1 year ago

it should only affect full text search and that works, testing more features against border effects

loicjaouen commented 1 year ago

possible blind spots:

loicjaouen commented 1 year ago

checking numbers of instances with a mix of requests like:

PREFIX knora-base: <http://www.knora.org/ontology/knora-base#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX knora-admin: <http://www.knora.org/ontology/knora-admin#>
select
#(count(?s) as ?c)
#(count(?p) as ?d)
#(count(?pp) as ?e)
(count(?oo) as ?f)
#?p ?project 
where {
  #bind(<http://rdfh.ch/projects/QNSP2JJRTEyh6A0ZtpRdPQ> as ?project)
  bind(<http://rdfh.ch/projects/0112> as ?project)
#  ?s ?p ?project .
  ?project ?pp ?oo.
}
#LIMIT 50

It all looks fine.

loicjaouen commented 1 year ago

preparing the release

loicjaouen commented 1 year ago

uploading image

loicjaouen commented 1 year ago

ready to release

next update is on friday when the dsp-api release is due

loicjaouen commented 1 year ago

release dsp-api v25 has been canceled