gustaveroussy / sopa

Technology-invariant pipeline for spatial omics analysis that scales to millions of cells (Xenium / Visium HD / MERSCOPE / CosMx / PhenoCycler / MACSima / etc)
https://gustaveroussy.github.io/sopa/
BSD 3-Clause "New" or "Revised" License
138 stars 15 forks source link

Min & Max aggregation methods #147

Open dancelestini opened 1 week ago

dancelestini commented 1 week ago

Hi Sopa team,

I'd like to request a feature that allows users to choose different aggregation methods for intensity measurements, rather than only calculating the average intensity. It would be very helpful to have options to compute minimum or maximum intensities in addition to the mean.

I suppose adding options in the function compute_table() would be the way to do that.

thanks for considering this :)

quentinblampey commented 1 week ago

Hi @dancelestini, indeed this is something that could be really interesting. I add this as a feature request. I'm a little bit busy with a new version of sopa that I want to release in mid-november, so it will not come before that, but I definitely keep it in mind!

dancelestini commented 1 week ago

Dear @quentinblampey, Thanks for your quick answer, and very happy to learn that a new version is coming out soon! Looking forward to testing it. Thanks also for taking into consideration my feature request. I will wait for it :)

quentinblampey commented 1 week ago

Actually adding the min/max is pretty easy, I implemented it quickly and it will be available in sopa==2.0.0, I'll let you know when it's released!

dancelestini commented 1 week ago

Ohh cool! This will really help us thanks a lot :)