gustavnikolaj / linter-js-standard-engine

Linter plugin for Standard Engine based linters.
ISC License
10 stars 6 forks source link

Does this package use the `ignore` settings in package.json? #54

Open saadq opened 7 years ago

saadq commented 7 years ago

If i have a packge.json file like this:

{
  "scripts": {
    "lint": "standard | snazzy"
  },
  "standard": {
    "ignore": [
      "some-dir-name"
    ]
  }
}

Is the package supposed to respect the ignore setting I have in the standard config? I don't get any errors from running npm run lint because some-dir-name is ignored, but when I open a file in some-dir-name in Atom, it shows linting errors within the editor. Is there a way to not have the linter run in files that should be ignored?

novemberborn commented 7 years ago

@saadq no that should work. Any chance you could share your product, or put up a repository that reproduces the issue?

saadq commented 7 years ago

I've added a simple repo here. If you run npm run lint or npm test, it doesn't display any errors. However, when I open a file that should be ignored in the editor, it displays this:

screen shot 2017-07-09 at 1 07 30 pm

Some additional details:

I believe I was also having the same issue when using linter-js-standard, so it's definitely possible I have something set up incorrectly. Please let me know if this issue isn't happening for you, and then maybe I can try with a clean install of atom with nothing but your package installed.

novemberborn commented 7 years ago

Thanks, I can reproduce that locally.

gustavnikolaj commented 7 years ago

Thanks for the report. I have opened a PR #55 with some exploration of the issue. Will have to look at it later. Sorry for the late reply, I've been on vacation and busy at work.