Open gustavnikolaj opened 7 years ago
Looking at this test failure:
2) should ignore /foo/bar/qux.js in /foo with globs ["bar"]
require('minimatch')('bar/qux.js','bar')
gives false
, but require('minimatch')('bar/qux.js','bar/*')
returns true
. That seems right to me. I suspect deglob
may be matching patterns against the file system and expanding matched directories?
Why don't we copy standard-engine
s ignore
implementation?
It'd be rad to get this feature!
I don't know what we're doing wrong, but as the tests shows,
minimatch
is not behaving as we expect.The
ignore
support in standard-engine comes from https://github.com/standard/deglob which depends on https://github.com/isaacs/node-glob which depends on minimatch, so it should be possible to figure it out :-)