search

gustavo-iniguez-goya / opensnitch

OpenSnitch is a GNU/Linux application firewall
GNU General Public License v3.0
395 stars 20 forks source link

Allow / Deny button vs combo box #13

Closed Ph0rk0z closed 4 years ago

Ph0rk0z commented 4 years ago

Allow or Deny, when making a rule uses the combo box widget. Since there will not be more than 2 choices, would a button be better? Having to select is an additional click + motion.

Not sure how much trouble this is. I found where it was defined but don't know enough of qt api to fix it.

gustavo-iniguez-goya commented 4 years ago

would a button be better? Having to select is an additional click + motion.

It depends. When you start using opensnitch you'll start applying rules, so you'll have to select [allow][deny] on demand. Once you have all the rules configured, since the default action can be configured, you should only need to click on [apply].

In the case of having only one button, what action should it be? the contrary to the default action?

Ph0rk0z commented 4 years ago

No, I mean for making rules initially. It removes an extra click when making rules: screenshot

My default action is deny for session but I want to allow the occasional program.

The one button thing could help for when you get bombed with connections, especially stale (or don't want a rule) ones but I know it's more complicated/low priority.

snitch2

gustavo-iniguez-goya commented 4 years ago

What about something like this? I agree with you, it's quite annoying to have to move the mouse to the left, select the action, and move it again to the right to click on Apply.

The default action would have the countdown. We need the top part of the dialog for the app title, so I think it's not the best place to put the buttons.

prompt2

Ph0rk0z commented 4 years ago

That looks good. Is where deny is the button to switch? If so apply should go to the right of it.

gustavo-iniguez-goya commented 4 years ago

Hey @Ph0rk0z , could you test this prompt dialog and let me know what do you think?

I think it's easier to allow/deny with this, as you suggested: prompt.py.txt prompt.ui.txt

rename both files to .ui and .py.

gustavo-iniguez-goya commented 4 years ago

I've been using the new dialog for a while, and I have to say that it was weird at first. I was used to click on the combo box to select the action to apply, so I used to click on the wrong button. But after sometime using the new dialog it's true that you save 1 click + the mouse motion