search

gustavo-iniguez-goya / opensnitch

OpenSnitch is a GNU/Linux application firewall
GNU General Public License v3.0
395 stars 20 forks source link

UI doesn't handle spaces in process.path well #24

Closed geeknik closed 4 years ago

geeknik commented 4 years ago

Hi and thank you for this software.

Describe the bug When the process.path contains a space, the UI doesn't handle it well.

To Reproduce See screenshot.

Expected behavior Spaces should be handled and the name of the process should not be shortened in the UI.

Screenshots Screenshot_2020-05-22_17-52-31

OS (please complete the following information):

gustavo-iniguez-goya commented 4 years ago

Thank you for the report geeknik!

Yes, you're right, I've just reproduced it. I'll take a look at it soon.

gustavo-iniguez-goya commented 4 years ago

@geeknik please, let me know if it solves the issue.

geeknik commented 4 years ago

I'm still seeing War instead of War Thunder. I've tried proc and ftrace and both return the same process.path.

gustavo-iniguez-goya commented 4 years ago

Sorry, dumb question just to be sure, did you compile latest sources or are you using the version from deb packages?

geeknik commented 4 years ago

I recompiled from source.

gustavo-iniguez-goya commented 4 years ago

Ok, bad news for me then. I'm installing Steam and will try to reproduce it.

Meanwhile, could you post the file ~/.local/share/Steam/steamapps/common/War Thunder/launcher? or tell me the process which is launched when the app is launched (for example: pgrep -a War)

I want to know the name of the process launched.

geeknik commented 4 years ago

/home/geeknik/.local/share/Steam/steamapps/common/War Thunder/launcher starts first, checks for updates, after clicking the Play button it launches ./linux64/aces from /home/geeknik/.local/share/Steam/steamapps/common/War Thunder. I wish they'd use _ instead of a space.

gustavo-iniguez-goya commented 4 years ago

I wish they'd use _ instead of a space.

agree.

I've tried to emulate it but it works fine here, and the steam installer complains on glx issues, so for now I cannot reproduce it reliably: image

Could you paste the output of these commands when the process "War Thunder" is running (or ? aces)?:

cat /proc/<PID was thunder>/cmdline
ls -l /proc/<PID was thunder>/cmdline

the Play button it launches ./linux64/aces

Sorry for so many questions O:), so is there a "War Thunder" process running or only that aces?

You can also test if at least the last commit is working by doing the following:

$ cp /usr/bin/telnet "/tmp/tel net" $ /tmp/tel\ net github.com

the app name should be tel net, if it is just tel then review the sources and the binary you're launching.

geeknik commented 4 years ago

Simply doing a git pull in my $GOPATH/src/github.com/gustavo-iniguez-goya/opensnitch/ directory didn't work, I had to remove it completely and re-run go get github.com/gustavo-iniguez-goya/opensnitch etc etc. Anyways, it works correctly now. Thank you.