UI: after maximizing the window and then minimizing it to task bar, the window does not display.

[themighty1]

After I maximize the window and then minimize it to the task bar/panel, it cannot unminimize the window anymore by clicking it's icon on the panel on it or Alt+Tabing it. However if I don't maximize the window and minimize it to panel, everything works fine and the window can be unminimized as you would expect.

[gustavo-iniguez-goya]

ok, reproduced and fixed. I'll commit soon.

[themighty1]

More fully addressed here: https://github.com/evilsocket/opensnitch/pull/315

[gustavo-iniguez-goya]

last PR works fine, but something has changed (just for the record):

0. show the stats window and resize it to (for example) 700x350
1. maximize the window
2. minimize by clicking on the [-] icon of the window
3. maximize by clicking on the systray icon
4. minimize by clicking on the [-] icon of the window
5. maximize by clicking on the systray icon
6. minimize by clicking on the [-] icon of the window
7. maximize by clicking on the systray icon
8. unmaximize by clicking on the 2nd button of the window [-][ ][x]
                                                              ^

before the last PR, the window was restored properly to the size before being maximized. With last PR, after the step 8. the window is restored to this (cinnamon):

I've only reproduced this odd behaviour after following the above steps. I don't usually maximize the window, so it's not a problem for me. I'd be surprised if someone runs into this problem... so let's fix it if someone complains.

[themighty1]

(before I comment, can we agree on the same terminology - when the window is minimized and we want to raise it, let's call this action "unminimize") So, in step 3, are you saying that if window is minimized and we click on the systray icon, it should become unminimized? On my system the only behaviour I've ever seen is that the window remains minimized, the click has no effect.

[gustavo-iniguez-goya]

Yes, clicking on the systray icon shows/hides the stats window (and unminimized), at least on Cinnamon and KDE. On Gnome-Shell as well, but depending on the version. And nn Unity it only shows the contextual menu. The logic is here: https://github.com/evilsocket/opensnitch/blob/master/ui/opensnitch/service.py#L137

Someone requested it sometime ago.

[themighty1]

Thanks, reproduced what you described on LXDE desktop. (I was running gnome classic when I spotted the bug.) For some reason I can't now even reproduce this bug even on gnome classis with my PR removed. @gustavo-iniguez-goya , could you please unmerge my PR until I find out what was actually causing it. Thanks.

[gustavo-iniguez-goya]

done. Yeah.. this is a bit crazy. Too many DEs, WMs..