search

gusutabopb / aioinflux

Asynchronous Python client for InfluxDB
MIT License
159 stars 31 forks source link

Properly escape extra_tags in user type #28

Closed iwoloschin closed 4 years ago

iwoloschin commented 5 years ago

When adding extra_tags to a user defined object the extra tags are not properly escaped to line protocol. This PR ensures the tag value is escaped, reusing the existing tag_escape implementation. I did not alter the tag name but I'd be fine adding that in as well if requested.

codecov-io commented 5 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files           9        9           
  Lines         545      545           
=======================================
  Hits          526      526           
  Misses         19       19
Impacted Files Coverage Δ
aioinflux/serialization/usertype.py 96.94% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b318662...2cbd252. Read the comment docs.

gusutabopb commented 4 years ago

Thanks! (And apologies for the being unresponsive for so long!)