search

gusztavvargadr / vagrant

Vagrant samples for creating Windows and Ubuntu environments
https://vagrantup.com
The Unlicense
16 stars 3 forks source link

MacOS support #82

Closed Ruluk closed 3 years ago

Ruluk commented 3 years ago

Context

I have a local branch ready to add support for building Windows VMs in MacOS in gusztavvargadr/packer. This PR must come first.

Commits

Fix: Local run triggers on MacOS.

Local run triggers should be binaries, not scripts. This fails in MacOS.

See https://www.vagrantup.com/docs/triggers/configuration#run

Fix: Immutable local file modifications.

These lines were being called multiple times, which is unnecessary.

gusztavvargadr commented 3 years ago

@Ruluk thanks for the effort, I greatly appreciate it.

I think there is a small issue with it, see my comment above.

If your goal is to make the packer repo work, I suggest to temporarily comment out those parts that would rely on this, I am planning to remove this repo dependency from there anyway, and open a PR for that, I guess that is a bigger work :)