search

gutenbergtools / autocat3

CherryPy App that serves dynamic content for Project Gutenberg
GNU General Public License v3.0
2 stars 6 forks source link

show zips, hide non-generated, update microdata #107

Closed eshellman closed 9 months ago

eshellman commented 9 months ago
eshellman commented 9 months ago

example: https://dev.gutenberg.org/ebooks/50500

gbnewby commented 9 months ago

Thanks - this looks good.

I'd like to tune things somewhat - this is overdue, and would have applied to the previous version.

If you'd like, let's go ahead and put this into production. Then, we can gather input from DP and others on improving the labels.

Here are my current thoughts on what to consider:

"No images" is EPUB2, right?

On Sat, Sep 23, 2023 at 7:17 AM Eric Hellman @.***> wrote:

example: https://dev.gutenberg.org/ebooks/50500

— Reply to this email directly, view it on GitHub https://github.com/gutenbergtools/autocat3/pull/107#issuecomment-1732328267, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQRDLWIEO6L52TO5EZA33LX33VOBANCNFSM6AAAAAA5DKU45U . You are receiving this because your review was requested.Message ID: @.***>

eshellman commented 9 months ago

most of the labels are database entries - no Autocat3 changes needed.

The other suggestions should be quick - I'll investigate.

On Sep 24, 2023, at 7:15 PM, Greg Newby @.***> wrote:

Thanks - this looks good.

I'd like to tune things somewhat - this is overdue, and would have applied to the previous version.

If you'd like, let's go ahead and put this into production. Then, we can gather input from DP and others on improving the labels.

Here are my current thoughts on what to consider:

  • "Print" doesn't seem to do anything.
  • Add our Mastodon social media link?
  • Labels for the downloads need reworking. I've been getting helpdesk inquiries that give me some ideas, but the challenge is communicating what's needed in just a few words. Thoughts including reordering: Format --> Choose how to read this book Read this book online: HTML5 --> Read online (web) EPUB3 (E-readers incl. Send-to-Kindle) --> Tablets and ereaders (EPUB3) Plain Text UTF-8 --> Plain text Download HTML5 zip archive --> Download HTML (zip) EPUB (older E-readers) --> Tablets and ereaders (legacy, EPUB2) EPUB (no images, older E-readers) --> Tablets and ereaders (no images EPUB2) Kindle --> Kindle (native K8; EPUB3 is recommended) older Kindles --> Kindle (older software, MOBI) There may be more files related to this item.

"No images" is EPUB2, right?

  • Can we add pop-up tooltips, to supplement the "?" icons that go to our bibrec explanation page?

On Sat, Sep 23, 2023 at 7:17 AM Eric Hellman @.***> wrote:

example: https://dev.gutenberg.org/ebooks/50500

— Reply to this email directly, view it on GitHub https://github.com/gutenbergtools/autocat3/pull/107#issuecomment-1732328267, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQRDLWIEO6L52TO5EZA33LX33VOBANCNFSM6AAAAAA5DKU45U . You are receiving this because your review was requested.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/gutenbergtools/autocat3/pull/107#issuecomment-1732693833, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHCGMN27HDHNT2DGMPML23X4C5HZANCNFSM6AAAAAA5DKU45U. You are receiving this because you authored the thread.

gbnewby commented 9 months ago

Sounds good. Please proceed with the changes that are quick, and then we'll get this into production.

We can then seek input on the database labels. If tooltips can be enabled, that will really help with being able to provide a longer explanation of each format without readers needing to visit the separate page describing file formats.

On Mon, Sep 25, 2023 at 6:34 AM Eric Hellman @.***> wrote:

most of the labels are database entries - no Autocat3 changes needed.

The other suggestions should be quick - I'll investigate.

On Sep 24, 2023, at 7:15 PM, Greg Newby @.***> wrote:

Thanks - this looks good.

I'd like to tune things somewhat - this is overdue, and would have applied to the previous version.

If you'd like, let's go ahead and put this into production. Then, we can gather input from DP and others on improving the labels.

Here are my current thoughts on what to consider:

  • "Print" doesn't seem to do anything.
  • Add our Mastodon social media link?
  • Labels for the downloads need reworking. I've been getting helpdesk inquiries that give me some ideas, but the challenge is communicating what's needed in just a few words. Thoughts including reordering: Format --> Choose how to read this book Read this book online: HTML5 --> Read online (web) EPUB3 (E-readers incl. Send-to-Kindle) --> Tablets and ereaders (EPUB3) Plain Text UTF-8 --> Plain text Download HTML5 zip archive --> Download HTML (zip) EPUB (older E-readers) --> Tablets and ereaders (legacy, EPUB2) EPUB (no images, older E-readers) --> Tablets and ereaders (no images EPUB2) Kindle --> Kindle (native K8; EPUB3 is recommended) older Kindles --> Kindle (older software, MOBI) There may be more files related to this item.

"No images" is EPUB2, right?

  • Can we add pop-up tooltips, to supplement the "?" icons that go to our bibrec explanation page?

On Sat, Sep 23, 2023 at 7:17 AM Eric Hellman @.***> wrote:

example: https://dev.gutenberg.org/ebooks/50500

— Reply to this email directly, view it on GitHub < https://github.com/gutenbergtools/autocat3/pull/107#issuecomment-1732328267>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AFQRDLWIEO6L52TO5EZA33LX33VOBANCNFSM6AAAAAA5DKU45U>

. You are receiving this because your review was requested.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/gutenbergtools/autocat3/pull/107#issuecomment-1732693833>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAHCGMN27HDHNT2DGMPML23X4C5HZANCNFSM6AAAAAA5DKU45U>.

You are receiving this because you authored the thread.

— Reply to this email directly, view it on GitHub https://github.com/gutenbergtools/autocat3/pull/107#issuecomment-1733725363, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQRDLSCWDD7S4XKRZ3SDHTX4GB7PANCNFSM6AAAAAA5DKU45U . You are receiving this because your review was requested.Message ID: @.***>

eshellman commented 9 months ago

"tooltips" usually refers to what most browsers do with "title" attributes. Currently, these say "Explain Dropbox.", "Explain Google Drive.", and "Explain OneDrive.". We could expand these.

A separate issue is that the links that these tooltips decorate have fragment identifiers that seem to have disappeared from the target page: https://www.gutenberg.org/help/bibliographic_record.html

I do not know where that page is maintained, it does not appear to be in github.

eshellman commented 9 months ago

with regard to the print button, https://github.com/gbnewby/gutenbergsite/pull/31

gbnewby commented 9 months ago

bibrec page: I just added it here: https://github.com/gbnewby/gutenbergsite/blob/master/site/help/bibliographic_record.md

It was part of the git tree and somehow was never added to the repo!

For tooltips: Yes, I think that approach would work if we can put a longer explanation. There is confusion over the "Older" format and probably over the "Kindle" format - I get several messages to help@ per week about these.

You should be able to add in the fragment identifiers (named anchor tags) as you add tooltips. Or let me know if you would rather I do it for the four tooltips that exist on the bibrec page already.

On Mon, Sep 25, 2023 at 8:48 AM Eric Hellman @.***> wrote:

"tooltips" usually refers to what most browsers do with "title" attributes. Currently, these say "Explain Dropbox.", "Explain Google Drive.", and "Explain OneDrive.". We could expand these.

A separate issue is that the links that these tooltips decorate have fragment identifiers that seem to have disappeared from the target page: https://www.gutenberg.org/help/bibliographic_record.html

I do not know where that page is maintained, it does not appear to be in github.

— Reply to this email directly, view it on GitHub https://github.com/gutenbergtools/autocat3/pull/107#issuecomment-1734014003, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQRDLTGO5MUCE2MPGQ6V23X4GRTZANCNFSM6AAAAAA5DKU45U . You are receiving this because your review was requested.Message ID: @.***>

eshellman commented 9 months ago

have put the latest code on gutenberg1, suggest you push the gutenbergsite changes there, restart, and do final test.

eshellman commented 9 months ago

Note that the ordering of file results is a database function and thus quite a bit more involved. Also, we will always have cases where html5 files are not successfully generated and the fallback to submitted still happens.

eshellman commented 9 months ago

we do not give the zip files a filetype, they get sorted last because all uncompressed files come first

gbnewby commented 9 months ago

Ok. Let's focus on the autocat3 changes first. Then we can look at the database changes.

On Mon, Sep 25, 2023 at 10:56 AM Eric Hellman @.***> wrote:

we do not give the zip files a filetype, they get sorted last because all uncompressed files come first

— Reply to this email directly, view it on GitHub https://github.com/gutenbergtools/autocat3/pull/107#issuecomment-1734216101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQRDLWEIC73JOG6OCI57U3X4HATBANCNFSM6AAAAAA5DKU45U . You are receiving this because your review was requested.Message ID: @.***>