search

gutenbergtools / ebookmaker

The Project Gutenberg tool to generate EPUBs and other ebook formats.
GNU General Public License v3.0
70 stars 17 forks source link

backend notification apparent false positive #207

Closed asylumcs closed 6 months ago

asylumcs commented 7 months ago

A recent backend notification recently came through for 22261. It included: "...sideborder.gif" does not appear to match the media type image/gif, as specified in the OPF file. All three gifs are reported as not being GIFs but they are:

capO.gif: GIF image data, version 89a, 72 x 69 capT.gif: GIF image data, version 89a, 62 x 74 sideborder.gif: GIF image data, version 89a, 15 x 157

It looks like EBM is not correctly detecting those as GIF images and then sending a false positive backend notification to the user.

eshellman commented 7 months ago

That message would be coming from the EPUB validator. How did you validate the three gifs?

On Dec 1, 2023, at 1:23 PM, Roger Frank @.***> wrote:

A recent backend notification recently came through for 22261. It included: "...sideborder.gif" does not appear to match the media type image/gif, as specified in the OPF file. All three gifs are reported as not being GIFs but they are:

capO.gif: GIF image data, version 89a, 72 x 69 capT.gif: GIF image data, version 89a, 62 x 74 sideborder.gif: GIF image data, version 89a, 15 x 157

It looks like EBM is not correctly detecting those as GIF images and then sending a false positive backend notification to the user.

— Reply to this email directly, view it on GitHub https://github.com/gutenbergtools/ebookmaker/issues/207, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHCGMNDDCHVX36F5FBOHB3YHIOB3AVCNFSM6AAAAABADHG4IWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDCMZXHA2DSMY. You are receiving this because you are subscribed to this thread.

eshellman commented 7 months ago

The image file in the epub is indeed a png file; I'm preparing a dot release for ebookmaker, I'll take a look to see what's going on - evidently ebookmaker's imgae code is writing a png and forgetting to change the file name.

On Dec 1, 2023, at 1:23 PM, Roger Frank @.***> wrote:

A recent backend notification recently came through for 22261. It included: "...sideborder.gif" does not appear to match the media type image/gif, as specified in the OPF file. All three gifs are reported as not being GIFs but they are:

capO.gif: GIF image data, version 89a, 72 x 69 capT.gif: GIF image data, version 89a, 62 x 74 sideborder.gif: GIF image data, version 89a, 15 x 157

It looks like EBM is not correctly detecting those as GIF images and then sending a false positive backend notification to the user.

— Reply to this email directly, view it on GitHub https://github.com/gutenbergtools/ebookmaker/issues/207, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHCGMNDDCHVX36F5FBOHB3YHIOB3AVCNFSM6AAAAABADHG4IWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDCMZXHA2DSMY. You are receiving this because you are subscribed to this thread.

nfenwick commented 7 months ago

Eric: "How did you validate the three gifs?"

I validated the three gifs with the file utility against the files that were sent up.

nfenwick commented 7 months ago

Whoops. Didn't realize I was logged in as Nell. nfenwick = asylumcs (rfrank).