gutenbergtools / libgutenberg

Common files used by Project Gutenberg python projects.
GNU General Public License v3.0
6 stars 3 forks source link

render BCE dates #32

Closed eshellman closed 11 months ago

eshellman commented 1 year ago

I looked up Julius Caesar in the catalog today, and noticed that his BCE dates display strangely on this page, and perhaps on other catalog pages I haven't run across: https://www.gutenberg.org/ebooks/authors/search/?query=caesar+julius

which has: Caesar, Julius -99--43

In PG's author records, BCE dates are represented as negative numbers, so that is displaying the raw form of Caesar's dates.

In trying to find any other places that might be displaying the raw date info, I discovered that the author browse pages are still using "BC" dates: https://www.gutenberg.org/browse/authors/c#a55441

which has: Caesar, Julius, 99 BC-43 BC

I believe we want BCE dates to display everywhere as they do on individual ebook landing pages, like this: https://www.gutenberg.org/ebooks/10657

which has: Caesar, Julius, 99 BCE-43 BCE

Thanks, Joyce

eshellman commented 1 year ago

Note: should be 'Caesar, Julius, 100 BC-44 BC'

eshellman commented 1 year ago

note: dates in the authors' page are formatted by the function format_author_dates in pgcat.phh which is NOT in github.

Easy fix, but management of php scripts needs cleanup first.

eshellman commented 1 year ago

There are 38 BCE authors in the db