search

gutmann / coarray_icar

Testing implementation of CoArrays for the basic ICAR algorithms
MIT License
5 stars 6 forks source link

"num_images()" invocations of "sync all"? #28

Open bcfriesen opened 6 years ago

bcfriesen commented 6 years ago

In commit c86ac77 ("now prints precipitation mid way through the domain after the run completes"), a loop was added to the end of test-ideal.f90 which invokes sync all num_images() times. This becomes expensive at large numbers of images. What was the intent of this?

https://github.com/gutmann/coarray_icar/blob/f1d8e4ac7306713292cacc789b7a885a987b87d0/src/tests/test-ideal.f90#L63

gutmann commented 6 years ago

This was added to keep all of print statements in order to make it easier for a human to parse the output. This entire section can be removed, it was simply added so I could confirm the algorithm was producing reasonable results (and not just complete garbage).