search

gutomaia / pyNES

Python programming for Nintendo 8 bits
BSD 3-Clause "New" or "Revised" License
1.22k stars 109 forks source link

use Pillow instead of PIL #4

Closed gutomaia closed 10 years ago

gutomaia commented 10 years ago

PIL as a graphic library is outdated and doomed. I should use Pillow from the beguining.

Context:

Sprite library uses PIL to import/export sprites from JPEG. However, PIL is outdated, we need to move on to Pillow. Basically, the change on library should only affect sprite tests.

popmilo commented 10 years ago

Does this mean project is finally moving on? ;) Awesome project and excellent idea! If you need help please let me know. My expertise is C64 and Atari 8bits, but would love to get my hands dirty with NES also. Greetings, Vladimir.

gutomaia commented 10 years ago

Yes... It's moving. It's a start. I'm polishing a lot of stuff on nodeNES. And now it's time for pyNES. It's all in the pipeline (https://waffle.io/gutomaia/gutomaia.github.com).

I will be very please if you could help. In fact, this issue, seems quite nice. Do you want to try it out?

popmilo commented 10 years ago

Yeah, why not :) Could you point me in right direction ? What's the correct workflow with pynes ?

ellisonleao commented 10 years ago

i can help too :smile:

gutomaia commented 10 years ago

Well... I need to write a Read.me about it. However, you just need to: 1) Fork to project 2) Create a branch from branch 0.0.x 3) Do the stuff 4) Send a pull request!

On your pull request comment and on all your commit, must have the hashtag #4, therefore it all will be linked here!

Run tests before each commit, they should help you.

@popmilo you are already assigned for this issue!

gutomaia commented 10 years ago

@ellisonleao I will prepare a issue on the board (https://waffle.io/gutomaia/gutomaia.github.com) and promote it for ready. Meanwhile, what are your knowlodge? How can I pick a feature that best suits you?

thanks, @ellisonleao and @popmilo, help are always welcome!

popmilo commented 10 years ago

Project forked, I'll work on this later in the evening, gotta go out now. All the best to all :)

ellisonleao commented 10 years ago

Hey @gutomaia , i guess i can help more on the python issues. My knowledge with C64 and Atari programming is minimal so i thing this project can be a nice way to go.

popmilo commented 10 years ago

Managed to work on this today. 1."remove PIL from the requirements.txt and also setup.py and put latest Pillow ilb"

Am I doing it right ? :)

ps. I never used "travis", so I don't know if I should do something with .travis.yml file in root folder (as I see it's doing something with requirements.txt) ?

gutomaia commented 10 years ago

Yes, you are on the right way.

There should be a mention on the setup.py. But that's ok. (it's a bug... do not fix that yet) I think that you are doing fine. Just remember to start your Branch from 0.0.x

You don't need to do anything on .travis.yml.

In order us to help. Just commit and let's and make the reference here with #4 hashtag.

popmilo commented 10 years ago

I did push something, don't know if its OK, still learning how to work with Git :)

gutomaia commented 10 years ago

No problem, let me try to help you, but so far, you're doing great. Now, take a look on the network map of the project (https://github.com/gutomaia/pyNES/network). You have a branch from 0.0.x, in the meantime that same branch didn't have an update. Therefore, in that case you didn't need to perform any merge.

Well, on github, they have a minimal tutorial (http://try.github.io/levels/1/challenges/1), and it's amazing.

Well, in your branch, there is a pull-request button, when you finish an issue, just press-it. For that example, make a pull-request to the from your branch do my branch 0.0.x. Do not click on the merge pull-request button yet.

popmilo commented 10 years ago

I have used mercurial for my projects in last couple of years, still haven't had too much reasons to use git that much... That is really nice tutorial, think I understand little more now. It's always nice to learn something new :)

gutomaia commented 10 years ago

Nice, that feature is done! Thanks!

popmilo commented 10 years ago

What is next ? :)

gutomaia commented 10 years ago

I'm looking for something.

What's your expedience with python?

popmilo commented 10 years ago

I use Python at daily work, using it for general computation (Ipython notebook). Did lots of graphics converters, editors, parsers, couple of wxpython applications... Think I can handle serious stuff, in any case I'll learn something by doing it ;)