search

gutschilla / elixir-pdf-generator

Create PDFs with wkhtmltopdf or puppeteer/chromium from Elixir.
MIT License
335 stars 71 forks source link

Remove specific env config #74

Closed vinibrsl closed 3 years ago

vinibrsl commented 4 years ago

Hey, thanks for this handy library that's been helping me on generating PDFs.

This fixes compiling non-default environments (such as sandbox, staging). It was causing Code.LoadError when trying to find /app/deps/pdf_generator/config/staging.exs (in my case, I was running mix deps.compile on my staging environment)

image

I have checked some other Elixir libraries and I tried a similar approach of not storing a specific config file for each environment, but only a config.exs, or none.

gutschilla commented 3 years ago

Hi @vnbrs , thanks a lot for your contribution. I simple words: I would agree.