search

guumaster / dir-cleaner

A golang CLI to scan and clean directories (mainly node_modules)
MIT License
7 stars 1 forks source link

upgrade to latest golang io package #1

Open gedw99 opened 8 months ago

gedw99 commented 8 months ago

Hey @guumaster

Nice tool and thank you for putting this out there.

Would you be open to adding multi path matching and perhaps upgrading to the latest golang io package ?

guumaster commented 8 months ago

@gedw99 thanks for testing this project. Happy to check PRs and merge.

gedw99 commented 8 months ago

Will make a PR. Am working on steep deadline so will swing back to this

gedw99 commented 2 weeks ago

hey @guumaster

forked over here: https://github.com/gedw99/dir-cleaner

upgraded everything.

now just working out how I can clean a nested folder structure where I need all the .bin, .dep folders to be deleted. There is a make target called "test" that creates this structure and attempts to clean it. If you could advise on that would be cool.

Its a structure I use for the EU Open Science Project, to allow mono repos style development:)

gedw99 commented 2 weeks ago

I got the test working. works really well !! nice work @guumaster

Let me know what you want me to do with this. NONE of your code has changed. I just did Spring Cleaning..

gedw99 commented 2 weeks ago

OOOPS. I renamed the git org in the go mod namespace...

Can rename it back.. I forgot that your wanted a PR back, and just renamed it because its easier with go module madness sometimes.

gedw99 commented 2 weeks ago

Its ready to be PR'edd back to you if you want it.

The test in windows fail. I suggest get it back into Origin and then we can have a look at whats happening in Windows. Main thing is that we have windows tests so we can see whats going on in CI.

https://github.com/gedw99/dir-cleaner/actions