guumaster / hostctl

Your dev tool to manage /etc/hosts like a pro!
http://guumaster.github.io/hostctl
MIT License
1.05k stars 45 forks source link

Added command for adding domains to hosts file and some tests #3

Closed pacodes closed 4 years ago

pacodes commented 4 years ago

A variant of the add domain command.

guumaster commented 4 years ago

Thanks for this PR @pacodes!

I've added some commits changing a bit the commonAddOptions to have a simpler input for people who want to use it as a module (even tough I duplicated part of the struct).

Also added same functionality for domains to set, so you can set full content of a profile too.

Thanks for the tests! I should add lots more.

guumaster commented 4 years ago

@pacodes If you were planning to add more things, you are more than welcome. Just be sure to create an issue beforehand to discuss about it and avoid duplicating work.

Again many thanks for contributing :1st_place_medal: !

pacodes commented 4 years ago

Ok @guumaster, thank you for your review and merge!