search

guumaster / hostctl

Your dev tool to manage /etc/hosts like a pro!
http://guumaster.github.io/hostctl
MIT License
1.04k stars 45 forks source link

brew install guumaster/tap/hostctl does not work on Apple M1 #75

Closed yaohuangguan closed 2 years ago

yaohuangguan commented 2 years ago

Error: Invalid formula: /opt/homebrew/Library/Taps/guumaster/homebrew-tap/hostctl.rb formulae require at least a URL Error: Cannot tap guumaster/tap: invalid syntax in tap!

guumaster commented 2 years ago

Hi @yaohuangguan thanks for reporting this. The publication as a homebrew formula is handled by goreleaser.

It looks like this is a goreleaser issue only addressing CPU.intel.

The formulae is updated with the latest release here: https://github.com/guumaster/homebrew-tap/blob/master/hostctl.rb.

I'll check on goreleaser docs/issues to see if they've addressed this.

yaohuangguan commented 2 years ago

what should i do in this case to work properly?

guumaster commented 2 years ago

@yaohuangguan actually this is an issue with the tool to release versions, so no much you can do unless you know something about goreleaser. It'll take some days until I get time to investigate further.

In the meantime, you can try the binary that are generated here: https://github.com/guumaster/hostctl/releases/tag/v1.1.1

UPDATE: I've added arm64 to goreleaser and generated a new release. Not sure if any of the binaries would work on your mac.

Fontinalis commented 2 years ago

@guumaster The above mentioned command does not work, but the binary does! Thanks for the fix and great work on this project! 👍🏻

frob commented 2 years ago

I added a PR to the guumaster/homebrew-tap repo that will add the ARM release to macos. This should make hostctl installable with homebrew on M1 macs.

guumaster commented 2 years ago

I've merged it, but I'm afraid that file is automatically updated by go-releaser GitHub action though

abarani commented 1 year ago

Just want to chime in to say that the current macOS release still does not work on Apple Silicon without Rosetta installed.

Apple Silicon support has only landed in Go 1.16: https://go.dev/doc/go1.16#darwin Bumping Go version to 1.16 from the current 1.14 should build a correct darwin arm64 binary file.