Closed deleolajide closed 5 years ago
This is great, thanks!
What you've added so far, is a way to change the URL that is 'announced' to the outside world. Your changes do not affect the actual URL on which the service is being made available.
I have three suggestions for improvements:
announcedContextRoot
, and add its value to the initialization here: https://github.com/guusdk/httpfileuploadcomponent/blob/4fb202d96b9c14d7bb7a2cee7f6da34454297a3e/src/main/java/nl/goodbytes/xmpp/xep0363/Launcher.java#L306-L308/
). Please add another option (contextRoot
) for this, and apply that option here: https://github.com/guusdk/httpfileuploadcomponent/blob/4fb202d96b9c14d7bb7a2cee7f6da34454297a3e/src/main/java/nl/goodbytes/xmpp/xep0363/Launcher.java#L329-L332The default value for contextRoot
should be: \
The default value for announcedContextRoot
should be the value of contextRoot
.
Oh and please update the readme's with the new options. See why it's taking me so long to update this thing? :)
… other than root
See https://github.com/guusdk/httpfileuploadcomponent/issues/15