guusdk / httpfileuploadcomponent

A XMPP External Component that implements XEP-0363 'HTTP File Upload'.
Apache License 2.0
8 stars 10 forks source link

Provide set/get methods for webPath used to set alternate web context… #19

Closed deleolajide closed 5 years ago

deleolajide commented 5 years ago

… other than root

See https://github.com/guusdk/httpfileuploadcomponent/issues/15

guusdk commented 5 years ago

This is great, thanks!

What you've added so far, is a way to change the URL that is 'announced' to the outside world. Your changes do not affect the actual URL on which the service is being made available.

I have three suggestions for improvements:

The default value for contextRoot should be: \ The default value for announcedContextRoot should be the value of contextRoot.

guusdk commented 5 years ago

Oh and please update the readme's with the new options. See why it's taking me so long to update this thing? :)

guusdk commented 5 years ago

15 has now been fixed with fd253d19d8578173637fb6bb82b3529acdb91dfa which incorporates your changes plus the feedback that I had.