guustnieuwenhuis / disableSite

Mura Plugin that disables a site
4 stars 0 forks source link

Error when activating plugin on site #1

Closed ghost closed 13 years ago

ghost commented 13 years ago

I successfully installed the plugin but when I choose a site to disable, I get an error when I reload the website.

The error is: variable [$] doesn't exist

This is on the latest version of Mura and Railo 3.3.0.026.

When I uncheck the box next to the site, the site loads again.

guustnieuwenhuis commented 13 years ago

Thank you for mentioning, I'll take a look over the weekend...

ghost commented 13 years ago

Thanks a lot

On Fri, Aug 26, 2011 at 2:39 PM, Lagaffe < reply@reply.github.com>wrote:

Thank you for mentioning, I'll take a look over the weekend...

Reply to this email directly or view it on GitHub: https://github.com/Lagaffe/disableSite/issues/1#issuecomment-1917147

guustnieuwenhuis commented 13 years ago

I've fixed the issue with version 1.0.1, can you please try and let me know if you still have the problem?

ghost commented 13 years ago

The error is gone. Thanks! I have a question, though. What is the behavior of the plugin? Does it just prevent the site for loading or should it display anything like "This site has been disabled." I'm just curious because when I activate it on a site, it tries to redirect to the "default" site. If the default site is disabled, it just goes back and forth between the two sites a few times and then stops. If that's normal, then it works fine. I just want to make sure.

guustnieuwenhuis commented 13 years ago

It prevents the site from loading and it will forward the visitor to the next site in the site order.

Indeed if you activate the plugin on all sites, you're create an endless loop.

ghost commented 13 years ago

Good to know. That works for me. Just wanted to make sure it wasn't a bug. Thanks for fixing the error!

On Sep 7, 2011, at 6:17 PM, Guust Nieuwenhuisreply@reply.github.com wrote:

It prevents the site from loading and it will forward the visitor to the next site in the site order.

Indeed if you activate the plugin on all sites, you're create an endless loop.

Reply to this email directly or view it on GitHub: https://github.com/Lagaffe/disableSite/issues/1#issuecomment-2034433