guyarb / golang-test-annotations

A github action which annotates failed tests.
MIT License
34 stars 10 forks source link

It seems like doesnt support go1.18? #18

Closed mtcoafun closed 2 years ago

mtcoafun commented 2 years ago

In action readme, the go version is set with go1.14.x, then I change it to

jobs:
  full_ci:
    strategy:
      matrix:
        go-version: [ 1.18 ]

but it didnt work in my workflow pipline...

image
guyarb commented 2 years ago

Hey @mtcoafun, thanks for letting me know I'll check that

guyarb commented 2 years ago

@mtcoafun please take a look at https://github.com/guyarb/golang-test-annotations-example

to run it on go1.18 the go.mod should be changed as well let me know if that didn't fix your run

mtcoafun commented 2 years ago

@mtcoafun please take a look at https://github.com/guyarb/golang-test-annotations-example

to run it on go1.18 the go.mod should be changed as well

let me know if that didn't fix your run

module github.com/mtcoafun/goutil

go 1.18

this is my projcet go.mod

guyarb commented 2 years ago

@mtcoafun, the annotation is pure Javascript code, there is no go code in golang-test-annotations, it only parses the go test output and the failure is in the run tests step so it seems like there is a problem with the required project in your go.mod - require golang.org/x/exp v0.0.0-20220328175248-053ad81199eb

mtcoafun commented 2 years ago

@guyarb but my other Go test workflow is working correctly

guyarb commented 2 years ago

@mtcoafun https://github.com/guyarb/goutil/commit/cbfaf027352a5bb1306762edfb198f3c43be51c1

mtcoafun commented 2 years ago

okay i will try to add this