search

guyasyou / Pure-Cookies-Notice

Cookies Notice allows once to notify users of anything, including the use of cookies (The Cookie Law Explained). Package for CMS Concrete5
https://www.concrete5.org/marketplace/addons/cookies-notice/
Other
1 stars 1 forks source link

Cookie configuration #10

Open mlocati opened 5 years ago

mlocati commented 5 years ago

We currently have some variables that are hard-coded. It would be nice to let users configure them:

  1. the name of the cookie What about letting users configure it in the "Advanced" tab?
  2. the duration of the cookie I'd add it to a configuration file
  3. the path of the cookie It's currently set to /. I'd add this value to a configuration file, and I'd default it to DIR_REL
  4. the domain of the cookie It's currently not set: I'd add it to a configuration file
guyasyou commented 5 years ago

the duration of the cookie and the path (and domain) of the cookie to config file - OK

the name of the cookie - maybe to config file too?

This block marked as Beginner, and I want it to stay simple.

mlocati commented 5 years ago

Well, we can just make this new cookieName field optional, and add it to the advanced tab. Allowing users to use a custom cookie name would allow using different site-wide alerts, each with its own cookie name...

mlocati commented 5 years ago

@guyasyou If you could review #11 I can submit another pull request with the changes described in this #10