Improve translation of missing required field messages

guyasyou / Pure-Cookies-Notice

Cookies Notice allows once to notify users of anything, including the use of cookies (The Cookie Law Explained). Package for CMS Concrete5

https://www.concrete5.org/marketplace/addons/cookies-notice/

Other

1 stars 1 forks source link

Improve translation of missing required field messages #5

Closed mlocati closed 5 years ago

mlocati commented 5 years ago

Translating concatenated strings is not translation-friendly.

For instance, I'd translate in Italian:

"Content is required" as "Il contenuto è richiesto"
"Position is required" as "La posizione è richiesta"

So, I'm having a hard time translating "%s is required" (it would need to be both "%s è richiesto" and "%s è richiesta"). This change would make translation life easier :wink:

guyasyou commented 5 years ago

How do you like that? https://github.com/guyasyou/Pure-Cookies-Notice/pull/5/commits/b4b0feab83a6863ca71b31ee751d08ee163da5ec

mlocati commented 5 years ago

Nice!