search

guyasyou / Pure-Cookies-Notice

Cookies Notice allows once to notify users of anything, including the use of cookies (The Cookie Law Explained). Package for CMS Concrete5
https://www.concrete5.org/marketplace/addons/cookies-notice/
Other
1 stars 1 forks source link

Add alert preview #9

Closed mlocati closed 5 years ago

mlocati commented 5 years ago

Closes #7

Preview:

preview

guyasyou commented 5 years ago

chrome_2019-01-14_23-07-17 I have error in packages/pure_cookies_notice/blocks/pure_cookies_notice/controller.php::344 Concrete5 8.4.4

mlocati commented 5 years ago

I should have fixed the error: now the code should run for concrete5 8.1+ (as specified in $appVersionRequired of package controller).

mlocati commented 5 years ago

In the new code, we could just use the $this->btHandle approach, but I prefer the first approach ($this->getBlockTypeID()) because it's faster, and I prefer using getters/setters instead properties. BTW we need to wait for the next concrete5 version in order to use getBlockTypeID (it has been introduced in #6976).

mlocati commented 5 years ago

Thanks!