search

guybedford / chomp

'JS Make' - parallel task runner for the frontend ecosystem with a JS extension system.
https://chompbuild.com
Apache License 2.0
138 stars 7 forks source link

fix: split paths with semicolon #142

Closed Aslemammad closed 1 year ago

Aslemammad commented 1 year ago

This was discussed in #140 for better platform compatibility.

guybedford commented 1 year ago

The original motivation for this was when dealing with windows paths like C:\\path:C:\\another-path being joined on a :. But since we are renormalizing the output now to use backtracking instead, I think this may not be as necessary?

Aslemammad commented 1 year ago

I see, that's reasonable! It's up to you at the end.

guybedford commented 1 year ago

Yeah it's just a breaking change like that other change, so would affect downstream at this point. We could certainly consider it for a major though.

Aslemammad commented 1 year ago

Let's close this then.

guybedford commented 1 year ago

Sure, and thanks for picking this question up from the discussion! If there are any other issues or extensions you're interested in working on always happy to discuss.

Aslemammad commented 1 year ago

Sure, I'd like to see chomp in a great stage that it deserves!