guybedford / chomp

'JS Make' - parallel task runner for the frontend ecosystem with a JS extension system.
https://chompbuild.com
Apache License 2.0
138 stars 7 forks source link

fix: clearer chompfile #155

Closed Aslemammad closed 1 year ago

guybedford commented 1 year ago

The install task doesn’t run by default though - we don’t assume the testing environment will run it.

On Sat, Oct 22, 2022 at 20:23 Mohammad Bagher Abiat < @.***> wrote:

@.**** commented on this pull request.

In chompfile.toml https://github.com/guybedford/chomp/pull/155#discussion_r1002625853:

cwd = 'test' -run = '../target/debug/chomp test' +run = 'chomp test'

After install task, wouldn't be the global chomp the new debugging build? So it's always updated and it's the target/debug/chomp!

Let me know if I'm wrong.

— Reply to this email directly, view it on GitHub https://github.com/guybedford/chomp/pull/155#discussion_r1002625853, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAESFSRAKNTSKCLDH3ZVDLDWESVTFANCNFSM6AAAAAARL7JSBU . You are receiving this because your review was requested.Message ID: @.***>

Aslemammad commented 1 year ago

I added it to the test deps, still it won't run?

Aslemammad commented 1 year ago

Anyways, if still this does not make sense, feel free to close it.

guybedford commented 1 year ago

Yeah install isn’t always reliable because we don’t have a reliable directory in the Env path to copy into. It could be cool to better provide ways to customize env paths per commands to allow this though… I think there may be some issues on that or if not we could plan some.

On Sat, Oct 22, 2022 at 20:34 Mohammad Bagher Abiat < @.***> wrote:

Anyways, if still this does not make sense, feel free to close it.

— Reply to this email directly, view it on GitHub https://github.com/guybedford/chomp/pull/155#issuecomment-1287994175, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAESFSTDSVCPRQU2FOLZ5NTWESW3LANCNFSM6AAAAAARL7JSBU . You are receiving this because your review was requested.Message ID: @.***>

Aslemammad commented 1 year ago

Aha, that's reasonable! Let's close.