search

guybedford / es-module-lexer

Low-overhead lexer dedicated to ES module parsing for fast analysis
MIT License
912 stars 47 forks source link

feat: skip trailing white space in dynamic import #162

Closed sapphi-red closed 8 months ago

sapphi-red commented 8 months ago

close #118

I'm not sure if this is always correct.

guybedford commented 8 months ago

I'm not sure this works either, it could be worth adding some edge cases for various parse goals to verify further.

sapphi-red commented 8 months ago

I added some more test cases that I can think of.

guybedford commented 8 months ago

Nice work, I can't think of any edge cases actually. Will release and let's see if anything comes up further.