search

guycalledfrank / bakery-issues

Bug tracker for Bakery
4 stars 0 forks source link

Light Color dosen't match #114

Closed hu78h closed 2 years ago

hu78h commented 3 years ago

Hello, after updating the latest patch, I noticed the Light color always doesn't match. image And I think it is due to commit d98bcf0c775b87513b2519449a35ff9ab0d61641 which "take light color temperature into account for direct/point/area lights"

pedropla commented 3 years ago

I have experienced this as well.

guycalledfrank commented 3 years ago

Ouch. OK, seems to be fixed now: https://github.com/guycalledfrank/bakery-csharp/commit/4feacfa0e83f90f883e2d597f30a74628049164b

pedropla commented 3 years ago

I'm still experiencing this issue with the latest version updated through the Bakery -> Utility -> Check for patches. Is the bug fix not in that branch or could it be something else?

Here's an example: image

guycalledfrank commented 3 years ago

Did you restart the editor after the "check for patches" and clicked "yes" on the window that appeared after the restart?

pedropla commented 3 years ago

Yes, and several updates since then.

guycalledfrank commented 3 years ago

What is your

pedropla commented 3 years ago

2019.4.28f, built-in, linear color space

guycalledfrank commented 3 years ago

I didn't have 2019.4.28, but I tried to reproduce it on 2019.4.3, and I couldn't. Both match buttons seem to work. Are these options disabled on your light?

image

pedropla commented 3 years ago

Yes the options are disabled. Should I try enabling them?

And just in case, these are the hashes of the versions I have from bakery-compiled-cver.txt (c4619eaa47417fe26ecc2f0d8182c893d528c3de) and bakery-csharp-cver.txt (3d0ba1f839bfbac4e2b600ea74f97b9489d755d7). If those aren't versions that include patches then perhaps there's a problem installing updates through the git system.

image

guycalledfrank commented 3 years ago

Your latest hash is correct, this is the version. Option should be off, as pictured. Can you send me this (or any where it's reproducible) project to test it? Maybe it's related to some project settings, I'm not sure.

pedropla commented 3 years ago

Do you need an entire project or would a prefab of a particular light with your script and the issue work? A prefab is easier to export, for a project I'd need to create a new bare bones project, import some lights and bakery and test, etc.

guycalledfrank commented 3 years ago

If this prefab shows the issue in a fresh project, then prefab is enough.

pedropla commented 2 years ago

Since it's working in recent Bakery builds I think it can be closed.