search

guycalledfrank / bakery-issues

Bug tracker for Bakery
4 stars 0 forks source link

Can't bake light probes in legacy mode #43

Closed Zurigan closed 3 years ago

Zurigan commented 3 years ago

This error gets thrown:

Using a 3070 GPU, Unity 2020.1.16

guycalledfrank commented 3 years ago

This looks like you're on a 3xxx GPU with RTX mode disabled. You should enable it. Did you run "Bakery -> Utilities -> Detect optimal settings?"

Zurigan commented 3 years ago

The same error happens with RTX mode enabled or disabled.

edit - using latest Nvidia driver (460.79)

guycalledfrank commented 3 years ago

Oops, sorry. indeed, Legacy light probe render didn't switch itself to RTX.

Fixed: https://github.com/guycalledfrank/bakery-csharp/commit/9debe3c91d6eb7e57472e0582afa4aa0f42a4dcd

You can download the github patch (https://geom.io/bakery/wiki/index.php?title=Github_access) or just replace two instances of "ftrace" (WITH quotes) with ftraceExe (without quotes) in ftRenderLightmap.cs

Zurigan commented 3 years ago

OK! This is looking a bit better now ... with L1:

image

With Legacy:

image

So ... still ringing but now mostly the right color ... think this might be at the level where players won't notice :)

guycalledfrank commented 3 years ago

That's it, I guess :(. I couldn't find a better way to convolve spherical harmonics when bright lights are used. Non-linear light probe fix in the shader is also fixing it all neatly without needing to change input values.