guycalledfrank / bakery-issues

Bug tracker for Bakery
4 stars 0 forks source link

ASE volume spec shader doesn't look like the shadergraph version #64

Open laurentopia opened 3 years ago

laurentopia commented 3 years ago

I'm trying to recreate the volume spec shader in ASE using the same custom function as the shader graph, for cleanliness and forward compatibility vs the Not_Lonely graph which is too custom and breaks easily (thanks to SRP). I'm getting weird poles in the diffuseSH-only as you can see image image

I'm attaching the ASE shader, if it fails to compile, drop a reference to BakeryDevoceLightmap.hlsl here image

the shader >>>>>>> impostor runtime with bakery volume.zip

guycalledfrank commented 3 years ago

Just got contacted by Amplify dev, seems like they want to implement their own version of Bakery graphs! (Did you write them too?)

As for your shader, I can't say why it works like this without knowing how you implemented it. Maybe you can try just removing unneded stuff from Vitaly's version?

laurentopia commented 3 years ago

I did attach the shader as a zip in the original post so you can see my implementation. It is a 1:1 conversion of your shadergraph so that each update you make to the lightmap decode hlsl benefits the ASE shader.

Modifying Vitaly's version was my first attempt. Unfortunately each trial result in a pink shader error and when I looked at the codegen there were syntax errors where the first parameter was missing, I couldn't trace the origin of that glitch.

Yes I was talking with Ricardo on discord this morning. Amplify wants to implement their own? Good news. Did they give you an ETA?

guycalledfrank commented 3 years ago

Vitaly was recently updating his shaders and also got into some problems, but managed to fix them. Maybe you should contact him directly? My ASE experience is zero. Haven't heard from Ricardo since that day, I guess it's not top priority for Amplify.