search

guycalledfrank / bakery-issues

Bug tracker for Bakery
4 stars 0 forks source link

RT AO intensity capped at 1 #79

Closed laurentopia closed 3 years ago

laurentopia commented 3 years ago

image image

guycalledfrank commented 3 years ago

Yeah it in fact works the same as in the lightmapper itself....

laurentopia commented 3 years ago

the baker goes beyond 1 in AO: AO intensity = 1 image AO intensity = 10 image

guycalledfrank commented 3 years ago

Sorry, my mistake. The scene I tested didn't have enough crevices, so I didn't see such a difference. Turns out, implementing proper intensity extrapolation is harder than I thought for the preview, since there is only 1 binary sample per frame, and you can't extrapolate when it's either 0 or 1. Anyway, implemented it properly now: https://github.com/guycalledfrank/bakery-compiled/commit/597cb021d697b3e7ff489b6495da65c932c2e652 https://github.com/guycalledfrank/bakery-rtpreview-csharp/commit/44a8d45b0425f6294850db09bba8739c49daeb64

laurentopia commented 3 years ago

hmm, now i'm getting this error when doing a preview in the scene view and the stand alone window image

guycalledfrank commented 3 years ago

Make sure to update from both bakery-compiled and bakery-rtpreview-csharp. Looks like you didn't update from one of them.