Transitioned codebase to bubbles/key keybinds

guyfedwards / nom

RSS reader for the terminal

GNU General Public License v3.0

372 stars 25 forks source link

Transitioned codebase to bubbles/key keybinds #68

Closed kanielrkirby closed 6 months ago

kanielrkirby commented 7 months ago

Fixes #64.

Added key.go to handle keybindings with bubbles/key.
Transitioned tui.go to use keybindings defined in key.go.
Added model.help to handle help messages.
Overrode the list.KeyMap.CancelWhileFiltering to q.
Added viewport full help menu, extracted help keys to key.go.
Changed g viewport keybinding to be consistent with list.
Extracted list overrides into key.go#SetOverrides.

guyfedwards commented 6 months ago

Great work, this cleans everything up considerably, found a bit of state weirdness.

Currently seeing an issue where if I go into filter, hit esc to cancel filter, then I am shown a minimal help and keybinds such as q or esc don't work.
We might benefit from a function we can call to update the keybinds, something like https://github.com/charmbracelet/bubbles/blob/48dffdd97e4ff8cb3fb16e6414bc8b6d8ae86a4c/list/list.go#L681 to help with state based keybinds outside of the list/viewport state (only worth doing if it will actually help with the issues mentioned)

kanielrkirby commented 6 months ago

I'll see if I can address those concerns here in the next couple days in my free time.

kanielrkirby commented 6 months ago

Addressed those issues. Looks like the state issues are caused by assigning list.KeyMap values directly. They provide methods SetHelp and SetKeys for this purpose, which they actually respect.

guyfedwards commented 6 months ago

Looks great, thanks @kanielrkirby