Closed kanielrkirby closed 6 months ago
Seems like this wasn't updated when the switch to sqlite happened, I don't use nom through docker so hadn't noticed, thanks for the fix.
Can you remove config.yml and nom.db from the changes, then I'll merge.
Absolutely, sorry about that. I'm horrible with seeing those changes, I really just need to run difftool
to be sure of what I'm actually commiting lol.
I think (?) I fixed it. I don't know why that happened, I remember explicitly not adding those.
Great, thanks @kanielrkirby
I'm not sure if there were things that used to be done implicitly, or what exactly has prompted this issue, but I've found that a fresh build and run of the binary with Docker results in an environment that doesn't have
gcc
oralpine-sdk
installed, and requires a couple build flags passed in, namelyCGO_ENABLED=1
andCGO_CFLAGS="-D_LARGEFILE64_SOURCE"
. The last flag can be ignored if we updatego-sqlite3
, which seems like the right move.All in all, I can say for sure that adding those packages and flags into the Dockerfile seems to solve all related issues completely. If you have any insights, please do let me know.
A slight alternative would be to continue with the update to sqlite3, but pass in CGO_ENABLED into the
Makefile
'sbuild
section, but this seems more well-scoped to the issue at hand. Let me know if you'd like me to change that though.Decided to open a PR as a form of discussion and potential solutions, rather than just an issue.
Changes
Dockerfile: