guyht / Glog

NodeJS and Git backed blogging engine
MIT License
52 stars 10 forks source link

Bringing down server #16

Closed wlaurance closed 11 years ago

wlaurance commented 12 years ago

Hey,

When I push to my blog_repo, my glog server craps out. I never have had this problem before.


Updating blog git repo
Stdout: Updating 530efd2..491dd6f
Fast-forward
 layout.jade     |    5 ++---
 public/main.css |   12 +++---------
 2 files changed, 5 insertions(+), 12 deletions(-)

Stderr: From github.com:wlaurance/fuzzy-octo-adventure
 * branch            master     -> FETCH_HEAD

Loading articles from blog_repo/articles
Reading file 05-24-12intro.txt
Reading file 05-25-12coffeescript.md
Reading file 6-1-2012billable.md
Read articles with headers: 
{ title: 'Introduction', date: '5/24/2012', author: 'wlaurance' }
Read articles with headers: 
{ title: 'What I love about CoffeeScript', date: '5/25/2012' }
Read articles with headers: 
{ title: 'Billable', date: '6-1-2012' }
preplugins
Searching this article, Introduction
Searching this article, What I love about CoffeeScript
Searching this article, Billable
Ditaa tags found in Billable
Compiling template for home page
Compiling template for individual pages
Starting server on port 8080

events.js:48
        throw arguments[1]; // Unhandled 'error' event
                       ^
Error: listen EADDRINUSE
    at errnoException (net.js:670:11)
    at Array.0 (net.js:771:26)
    at EventEmitter._tickCallback (node.js:190:38)
wlaurance commented 12 years ago

I am at 8fcd40cd2a75a6c4

wlaurance commented 12 years ago

From what I can tell, the only way this line of code "Starting server on port 8080" prints is if node server.js is run again.

guyht commented 12 years ago

The error means port 8080 is already in use, probably because glog is already running.

Try ps -ef | grep glog

On Sunday, July 8, 2012, Will Laurance wrote:

Hey,

When I push to my blog_repo, my glog server craps out. I never have had this problem before.


Updating blog git repo
Stdout: Updating 530efd2..491dd6f
Fast-forward
 layout.jade     |    5 ++---
 public/main.css |   12 +++---------
 2 files changed, 5 insertions(+), 12 deletions(-)

Stderr: From github.com:wlaurance/fuzzy-octo-adventure
 * branch            master     -> FETCH_HEAD

Loading articles from blog_repo/articles
Reading file 05-24-12intro.txt
Reading file 05-25-12coffeescript.md
Reading file 6-1-2012billable.md
Read articles with headers:
{ title: 'Introduction', date: '5/24/2012', author: 'wlaurance' }
Read articles with headers:
{ title: 'What I love about CoffeeScript', date: '5/25/2012' }
Read articles with headers:
{ title: 'Billable', date: '6-1-2012' }
preplugins
Searching this article, Introduction
Searching this article, What I love about CoffeeScript
Searching this article, Billable
Ditaa tags found in Billable
Compiling template for home page
Compiling template for individual pages
Starting server on port 8080

events.js:48
        throw arguments[1]; // Unhandled 'error' event
                       ^
Error: listen EADDRINUSE
    at errnoException (net.js:670:11)
    at Array.0 (net.js:771:26)
    at EventEmitter._tickCallback (node.js:190:38)

Reply to this email directly or view it on GitHub: https://github.com/guyht/Glog/issues/16

wlaurance commented 12 years ago

So when the server fired up the plugin array looks like this

1cb: wcb Ncb: N callbacks for plugins N+1: the original cb given to render_articles

On __render 1cb: wcb Ncb: N callbacks for plugins N+1: the original cb given to render_articles 2Ncb:N more callbacks for plugins 2N+1: the new cb for update articles.

So the N+1 callback was the original callback when starting the server, thus it indeed attempts to listen on the same port and throws the addr in use error.

guyht commented 12 years ago

Have merged #17. Going to to a proper regression test of it tonight and prepare a new release

wlaurance commented 11 years ago

Closing this issue