search

guyht / Glog

NodeJS and Git backed blogging engine
MIT License
52 stars 10 forks source link

node_modules #29

Open wlaurance opened 10 years ago

wlaurance commented 10 years ago

Since this is a platform and not a library, have you considered add node_modules to git?

I have gone back and forth with this and now I generally add node_modules to projects that aren't libraries where I want to know exactly what versions of dependencies are running.

Are you for adding node_modules to Glog's git or should we just .gitignore them?

guyht commented 10 years ago

I like to try to keep the project up to date with the latest libraries. In order to make sure people are using a version of the libraries that work with Glog, using npm shrinkwrap might be a better choice. It locks down your dependencies so when you run npm install, you get an exact replica of the dependencies from when npm shirnkwrap was run.

This would avoid issues like the one with Jade

wlaurance commented 10 years ago

I think shrinkwrap is a good choice.