Upgrade to express - Githubissues

guyht / Glog

NodeJS and Git backed blogging engine

MIT License

52 stars 10 forks source link

Upgrade to express #6

Closed wlaurance closed 12 years ago

wlaurance commented 12 years ago

I was having issue installing Glog, and realized that connect was at 2.3.0, instead of 1.8.4 per package.json. I installed connect@1.8.4 and it worked correctly. However I see that express maps 1 to 1 (at least with the functions you have used) with connect and Glog seems to work as expected with express@2.5.9.

Another solution would be locking connect@1.8.4, but switching to express will scale better.

guyht commented 12 years ago

Connect is a bit more lightweight but might be a good idea to switch to express. Will have a quick look over it tomorrow and merge. Thanks.

guyht commented 12 years ago

Just tested this, the first commit works great, but the 2nd one breaks the test cases. See my previous comment for the fix.

I have merged the fist commit, if you make the changes to the 2nd one I will merge that one as well.

Thanks for your help, much appreciated.