Hide loading spinner in finnaly block

guylabs / ion-autocomplete

A configurable Ionic directive for an autocomplete dropdown

MIT License

264 stars 88 forks source link

Hide loading spinner in finnaly block #203

Closed BioPhoton closed 8 years ago

BioPhoton commented 8 years ago

Now the loading spinner hides only if the request resolves. This is bad for rejected requests. pleas move the state change into the finally block of the promise.

THX!

guylabs commented 8 years ago

HI @BioPhoton,

good point I will change that when I got the time to. If you have time you could provide a PR for that. This would be really appreciated. 👍

Thanks and regards,

Guy

guylabs commented 8 years ago

Hi @BioPhoton

this has already been done in this commit https://github.com/guylabs/ion-autocomplete/commit/c80103e98dd949e535f1faa3558d76b42494b1b4. So I will close this as fixed.

Thanks and regards,

Guy