search

guylabs / macstrap-config

Default configuration repository for https://github.com/guylabs/macstrap
MIT License
8 stars 11 forks source link

Config assumes M1 Mac #4

Open JLLeitschuh opened 2 years ago

JLLeitschuh commented 2 years ago

If you attempt to install rosetta on a non-M1 mac, the config fails.

https://github.com/guylabs/macstrap-config/blob/0a1b7d18717fa7da1ab3bd2585e3d94b84228a11/custom-scripts/pre-install-0-setup.sh#L35-L36

Additionally, this line also assumes an M1 mac book pro: eval "$(/opt/homebrew/bin/brew shellenv)"

https://github.com/guylabs/macstrap-config/blob/9e033771b67212c03518da54b8e1c0dbfa2039ed/configs/dotfiles/.zshrc#L64-L65

guylabs commented 2 years ago

Yes, it does not support X86 architectures anymore. This config is my personal config as a reference and I'm keeping it up to date with the hardware I have. You'd need to fork from around here https://github.com/guylabs/macstrap-config/commit/45614f682163aa5e93b381c3c79386185f4519ba as there the config started to support arm64 architecture.

Ok for you to close the issue as not planned ?

JLLeitschuh commented 2 years ago

The only two locations currently causing issues are the locations listed above. Other places in the code seem to attempt to mitigate this. Could something similar be used?

https://github.com/guylabs/macstrap-config/blob/895c73957ce52b2c9f15c93dcdc1c3349aaba91e/commands/install.sh#L5-L11

guylabs commented 2 years ago

Yes we can use that. Feel free to create a pull request with your state what works on x86. That would be great!