guyromb / cordova-open-native-settings

Plugin to open native screens of iOS/android settings (maintained, end-2020)
http://gsrweb.net
MIT License
113 stars 105 forks source link

iOS app gets rejected because of use of "prefs:root" or "App-Prefs:root" private API's. #36

Closed ipehimanshu closed 5 years ago

ipehimanshu commented 6 years ago

5.0.0 Binary Rejected Aug 31, 2018 Guideline 2.5.1 - Performance - Software Requirements Your app uses the "prefs:root=" non-public URL scheme, which is a private entity. Here is their suggested solution: Guideline 2.5.1 - Performance - Software Requirements

Your app uses the "prefs:root=" non-public URL scheme, which is a private entity. The use of non-public APIs is not permitted on the App Store because it can lead to a poor user experience should these APIs change.

Continuing to use or conceal non-public APIs in future submissions of this app may result in the termination of your Apple Developer account, as well as removal of all associated apps from the App Store.

Next Steps

To resolve this issue, please revise your app to provide the associated functionality using public APIs or remove the functionality using the "prefs:root" or "App-Prefs:root" URL scheme.

If there are no alternatives for providing the functionality your app requires, you can file an enhancement request.

So any one please help us to resolve this issue

goinnn commented 5 years ago

Yes I get the same. If I remove "this if" https://github.com/guyromb/Cordova-open-native-settings/blob/master/src/ios/NativeSettings.m#L20 and this config https://github.com/guyromb/Cordova-open-native-settings/blob/master/plugin.xml#L36 all works. Tested in ios9-ios11.

@guyromb please could you tell us what you think about it?

Today I am going to do a pull request

guyromb commented 5 years ago

PR: https://github.com/guyromb/Cordova-open-native-settings/pull/34 Merged

goinnn commented 5 years ago

With #34 I will get the same error. iOS don't want you use prefs API. You can not have pref API in URL Types. :-(

https://forum.starling-framework.org/topic/appstore-rejection

goinnn commented 5 years ago

@guyromb Please could you reopen this issue?

ipehimanshu commented 5 years ago

so is this issue now solved?

On Fri, Oct 19, 2018 at 5:42 PM, Guy Rombaut notifications@github.com wrote:

Closed #36 https://github.com/guyromb/Cordova-open-native-settings/issues/36 via

37 https://github.com/guyromb/Cordova-open-native-settings/pull/37.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/guyromb/Cordova-open-native-settings/issues/36#event-1914597722, or mute the thread https://github.com/notifications/unsubscribe-auth/AZathtTRCNujr0agIroBtEzQUDkRvlj-ks5umcGbgaJpZM4WYabw .

ipehimanshu commented 5 years ago

if yes then can you please say which version should i installed for this plugin ?

goinnn commented 5 years ago

@ipehimanshu yes you can patch your plugin with this commit aa53c9112109e622b7125ce58545d7ef7af2a063 or you can install from github directly master branch

alexhisen commented 5 years ago

@guyromb Are you going to be publishing an updated version on npm? And what is the status of this plugin on iOS 11 - does it work?

jasvindersingh-evon commented 5 years ago

@guyromb: Is the app still getting rejected on Apple store?

alexhisen commented 5 years ago

No

Get Outlook for Androidhttps://aka.ms/ghei36

On Thu, May 30, 2019 at 12:57 AM -0700, "jasvindersingh-evon" notifications@github.com<mailto:notifications@github.com> wrote:

@guyrombhttps://github.com/guyromb: Is the app still getting rejected on Apple store?

- You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/guyromb/cordova-open-native-settings/issues/36?email_source=notifications&email_token=AEVLDP373TURZV5RVZARZNTPX6CFFA5CNFSM4FTBU3YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWRU4IA#issuecomment-497241632, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEVLDPZM2KC7RTULLD6MH6LPX6CFFANCNFSM4FTBU3YA.