When a module fails to build, CustomPiOS keeps building the other modules

guysoft / CustomPiOS

A Raspberry Pi and other ARM devices distribution builder

GNU General Public License v3.0

515 stars 149 forks source link

When a module fails to build, CustomPiOS keeps building the other modules #18

Closed guysoft closed 6 years ago

guysoft commented 6 years ago

A failure should halt the build, the problem happens because there is no testing in /distro/src/workspace/chroot_script that is generated by execution_order.py.

The code there should be improved.

foosel commented 6 years ago

Just ran into this as well. Was confused why my image wasn't working, then noticed that the OctoPi build had run into a network error half way through but no error was generated :/

guysoft commented 6 years ago

Yes, also @toddejohnson ran in to it. I was going to do this, even added echo_red and echo_green so we could actually print this in color, but never managed to capture the failures. If anyone has time to do this then awesome, if not I will get to it eventually.