Closed umlaeute closed 1 year ago
i wonder whether the PKGUPGRADE_CLEANUP
flag should somehow inherit the BASE_APT_CLEAN
value (unless set by the user).
but that's mostly a design choice, how independent modules must be (and whether the base
module is an exception)
Thanks for fixing the square brackets for string comparison
While b47534cc33a0b65ea5d2ee107cefda66470cb226 provides a
PKGUPGRADE_CLEANUP
variable to prevent thepkgupgrade
module from runningapt-get clean
in the cleanpu script, thebase
module still unconditionally clears the apt-cache: https://github.com/guysoft/CustomPiOS/blob/8a3a002570c46409372349853622f0619baefc87/src/modules/base/end_chroot_script#L41-L42This PR introduces a new
BASE_APT_CLEAN
variable, that can be set to anything but the defaultyes
to preventapt-get clean
from being run.while I edited the files i couldn't resist the urge to drop some unnecessary bashisms and replace the oldstyle command substitution
``
with the modern, stackable$()
(but these changes are in separate commits, so feel free to ignore them)