search

guysoft / CustomPiOS

A Raspberry Pi and other ARM devices distribution builder
GNU General Public License v3.0
516 stars 150 forks source link

fix: fix handling of resolv.conf file #226

Closed KwadFan closed 3 months ago

KwadFan commented 3 months ago

Includes changes if resolv.conf is a symbolic link

Mostly affected are armbian based images.

If you want to go through whole logs of build please see:

https://github.com/KwadFan/MainsailOS-dev/actions/runs/10264062537

As earlier said on discord:

What it does:

  1. Checking if resolv.conf is a symlink, if yes store target location in a temporary file on /
  2. Altering resolv.conf, based on setup either your desired default or based on BASE_USE_ALT_DNS
  3. After all desired modules, running end_chroot and restore either link or backuped resolv.conf(depending if temporary file exist)

I think this is less invasive as PR #224 Regards Kwad

guysoft commented 3 months ago

Ok looks good - did you test it?

KwadFan commented 3 months ago

Yes, see this run https://github.com/mainsail-crew/MainsailOS/actions/runs/10264564806

Also flashed an Image, see Bildschirmfoto_2024-08-06_13-30-10 Bildschirmfoto_2024-08-06_13-18-45

https://github.com/mainsail-crew/MainsailOS/actions/runs/10264564806/job/28398906631#step:3:1669 https://github.com/mainsail-crew/MainsailOS/actions/runs/10264564806/job/28398906631#step:3:6600

For reference lines from build log

guysoft commented 3 months ago

@KwadFan Is this ready to be merged?

KwadFan commented 3 months ago

@KwadFan Is this ready to be merged?

You wanted it to test, so, did you test? From my side, we are in LGTM state ;)

guysoft commented 3 months ago

Ah, yes I did, will do when I have time.

guysoft commented 3 months ago

Not getting to it, people are reporting that its needed, merging