guysoft / CustomPiOS

A Raspberry Pi and other ARM devices distribution builder
GNU General Public License v3.0
514 stars 149 forks source link

[feature] set name of img on release #45

Closed guysoft closed 4 years ago

guysoft commented 5 years ago

See: https://github.com/zynthian/zynthian-sys/issues/66#issuecomment-468244913

tl;dr CustomPiOS should have a variable that lets you set the file name of the image. Should be used here: https://github.com/guysoft/CustomPiOS/blob/devel/src/release#L16

cc @jofemodo

WheresWaldo commented 5 years ago

I agree with this or at the very least include the versioning used in Distro-name/src/config to add the versioning number to the build process

guysoft commented 5 years ago

@WheresWaldo That happens in the base module: https://github.com/guysoft/CustomPiOS/blob/devel/src/modules/base/start_chroot_script#L55

Release takes care of the zip and image name. The build only handles what is in the image. not the external name.

WheresWaldo commented 5 years ago

Maybe I am not understanding how to actually do it. Or maybe this wasn't the correct feature request. What I want is the final image created not to be called YYYY-MM-DD-raspbian-stretch-lite.img but rather by the DIST_NAME-DIST_VERSION.img

guysoft commented 5 years ago

@WheresWaldo Yes, this is why this issue is open, note I wrote where it needs to be changed. $FILENAME should have more options.

WheresWaldo commented 5 years ago

Sorry for being so dense, but I have one more question with regard this option,

In my distro, I am building everything in base( ) under export MODULES=, would I just add release to my list of modules? Such as this:

export MODULES="base(list of modules),release" or would it be export MODULES="base(list of modules,release)"

guysoft commented 4 years ago

@WheresWaldo release should not part the modules IMHO, because it does not alter the actual data inside the image. I could add some setting such as RELEASE_ON_BUILD=true

guysoft commented 4 years ago

Ok, no document in the wiki yet, but added two new variables you can set in config:

BASE_RELEASE_IMG_NAME=default
BASE_RELEASE_ZIP_NAME=default

If you change them to something other than default it should rename the image. I haven't fully tested it so please report if you have any issues @WheresWaldo @jofemodo