search

guysoft / CustomPiOS

A Raspberry Pi and other ARM devices distribution builder
GNU General Public License v3.0
514 stars 149 forks source link

Admin Toolkit seems broken because of duplicate fi statement #87

Closed s00500 closed 3 years ago

s00500 commented 3 years ago

https://github.com/guysoft/CustomPiOS/blob/b1f9c18cbdb5eda0019814591495e9ad62a6e964/src/modules/admin-toolkit/start_chroot_script#L153

Does not look intended and breaks my build when using admin-toolkit, shall it be removed ?

guysoft commented 3 years ago

Its from a commit @asdf1nit did about a year ago: https://github.com/guysoft/CustomPiOS/commit/124509df44310002668cb0a87f74c8aca9261d07#diff-4c1588d6ea919feb40b3cfea910aff18142aa2b9c204c0ad5a8ff962aa8a0149R152

I guess its his call, but it looks like a blunt syntax error. Would you like to PR for it or should I just remove it?

s00500 commented 3 years ago

PR is ready :-)

s00500 commented 3 years ago

Awesome =D