guysoft / FullPageOS

A raspberrypi distro to display a full page browser on boot
GNU General Public License v3.0
3.86k stars 237 forks source link

README curl download command downoads image to raspbian_latest and not to actual image name #144

Closed bhartvigsen closed 7 years ago

bhartvigsen commented 7 years ago

What were you doing?

Building FullPageOS

What did you expect to happen?

Successful build after following instructions

What happened instead?

Build failure

Was there an error message displayed? What did it say?

Error: could not find image: ++++ previous_command='echo "Error: could not find image: $BASE_ZIP_IMG"' ++++ this_command='exit 1' +++ exit 1

[Can be found in /etc/fullpageos_version ALWAYS INCLUDE.] Nope: cat: /etc/fullpageos_version: No such file or directory

This project fails to build on Ubuntu 16.04.2 LTS. I followed the instructions in the README verbatim and got the above error. I had no errors or problems when setting up the dependencies, only when trying to run build_Dist

guysoft commented 7 years ago

Build says "Error: could not find image: $BASE_ZIP_IMG"' Did you place the latest raspbian-lite image in src/image?

bhartvigsen commented 7 years ago

I think I may have figured out the problem. In your instructions, it says to run this command:

curl -J -O -L  http://downloads.raspberrypi.org/raspbian_latest

This places a file called 'raspbian_latest' in the image directory, however your script expects to locate a filename containing '-raspbian.zip' so by manually renaming the file the build is able to run as expected. My advice would be to update the README to change the command to:

curl -J -L  http://downloads.raspberrypi.org/raspbian_latest > raspbian_latest-raspbian.zip
guysoft commented 7 years ago

Yes I was just typing that and you figured it out before I sent the comment :) Ideally I want to add a command from CustomPiOS that I wrote that downloads the latest image with the right name. At the moment its a function here